Add Dockerfiles and docker-compose file #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also mount source directories as read-only (just in case)
|
Not sure why the one build is failing |
|
@anthonynguyen I don't know why that failed either, it happens sometimes and I haven't figured it out. I restarted that job! |
|
Looks good at a glance, I don't really use docker but I'm fine merging this and fixing anything if someone finds it's not working! Thank you for this!! ❤️ bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Oct 11, 2017
1106: Add Dockerfiles and docker-compose file r=carols10cents This PR resolves #943. I'm pretty sure I've made it so running `docker-compose up` will just work, but someone else will definitely have to verify. I also wanted to spawn a Minio (or something similar) service to replace S3, but currently the S3 host isn't configurable so I might do all that in another PR.
Build failed |
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Oct 14, 2017
1106: Add Dockerfiles and docker-compose file r=carols10cents This PR resolves #943. I'm pretty sure I've made it so running `docker-compose up` will just work, but someone else will definitely have to verify. I also wanted to spawn a Minio (or something similar) service to replace S3, but currently the S3 host isn't configurable so I might do all that in another PR.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #943.
I'm pretty sure I've made it so running
docker-compose upwill just work, but someone else will definitely have to verify.I also wanted to spawn a Minio (or something similar) service to replace S3, but currently the S3 host isn't configurable so I might do all that in another PR.